Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mis/portal): 增加获取 SCOW API 版本的接口 #1381

Merged
merged 8 commits into from
Aug 1, 2024

Conversation

tongchong
Copy link
Contributor

@tongchong tongchong commented Jul 29, 2024

做了什么

增加了一个proto接口 getVersion,可以用来获取scow的版本,方便其它服务判断当前部署的scow是否支持某些功能

Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: efc6a98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@scow/grpc-api Minor
@scow/portal-server Patch
@scow/mis-server Patch
@scow/protos Patch
@scow/lib-hook Patch
@scow/lib-operation-log Patch
@scow/lib-scheduler-adapter Patch
@scow/lib-server Patch
@scow/lib-web Patch
@scow/audit-server Patch
@scow/mis-web Patch
@scow/portal-web Patch
@scow/ai Patch
@scow/auth Patch
@scow/gateway Patch
@scow/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@tongchong tongchong marked this pull request as ready for review July 30, 2024 01:50
@pkuhpc-review-bot pkuhpc-review-bot bot added the Code-ReviewRequested Code Review Requested label Jul 30, 2024
@pkuhpc-review-bot pkuhpc-review-bot bot requested a review from ddadaal July 30, 2024 01:50
apps/portal-server/tests/utils/config.test.ts Outdated Show resolved Hide resolved
protos/common/config.proto Outdated Show resolved Hide resolved
apps/portal-server/src/services/config.ts Outdated Show resolved Hide resolved
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ChangeRequested and removed Code-ReviewRequested Code Review Requested labels Jul 30, 2024
Copy link
Member

@ddadaal ddadaal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改完直接合并就行

protos/common/config.proto Outdated Show resolved Hide resolved
@tongchong tongchong requested a review from ddadaal August 1, 2024 01:58
@pkuhpc-review-bot pkuhpc-review-bot bot added Code-ReviewRequested Code Review Requested and removed Code-ChangeRequested labels Aug 1, 2024
@tongchong tongchong changed the title feat(mis/portal): 增加获取SCOW版本的接口 feat(mis/portal): 增加获取 SCOW API 版本的接口 Aug 1, 2024
@tongchong tongchong merged commit 4bef1b3 into master Aug 1, 2024
4 checks passed
@tongchong tongchong deleted the feat-add-version-req branch August 1, 2024 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code-ReviewRequested Code Review Requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants